spacewander commented on a change in pull request #5675:
URL: https://github.com/apache/apisix/pull/5675#discussion_r762550646
##########
File path: apisix/cli/file.lua
##########
@@ -65,8 +65,15 @@ local function resolve_conf_var(conf)
local var_used = false
-- we use '${{var}}' because '$var' and '${var}' are taken
-- by Nginx
- local new_val = val:gsub("%$%{%{%s*([%w_]+)%s*%}%}", function(var)
- local v = getenv(var)
+ local new_val =
val:gsub("%$%{%{%s*([%w_]+[%:%:[%w%-%.%:%?%/=]+]?)%s*%}%}", function(var)
Review comment:
Sure. But we don't need to be too strict with `[%w%-%.%:%?%/=]+`? What
if people want to use space in the default value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
