juzhiyuan commented on a change in pull request #5736:
URL: https://github.com/apache/apisix/pull/5736#discussion_r764570848



##########
File path: docs/en/latest/plugins/ldap-auth.md
##########
@@ -41,12 +41,13 @@ This authentication plugin use 
[lualdap](https://lualdap.github.io/lualdap/) plu
 
 ## Attributes
 
-| Name     | Type   | Requirement | Default | Valid | Description              
                                                                                
                                                        |
-| -------- | ------ | ----------- | ------- | ----- | 
----------------------------------------------------------------------------------------------------------------------------------------------------------------
 |
-| base_dn | string | required    |         |       | the base dn of the `ldap` 
server (example : `ou=users,dc=example,dc=org`)   |
-| ldap_uri | string | required    |         |       | the uri of the ldap 
server  |
-| use_tls | boolean | optional    |    `true`     |       | Boolean flag 
indicating if Transport Layer Security (TLS) should be used. |
-| uid | string | optional    |     `cn`      |     | the `uid` attribute |
+| Name     | Type    | Requirement | Default | Valid |                         
                                                                                
  |Description                                                                  
                                                                                
    |
+| -------- | ------- | ----------- | ------- | ----- | 
----------------------------------------------------------------------------------------------------------------------------------------------------------------
 |
+| base_dn  | string  | required    |         |       | the base dn of the 
`ldap` server (example : `ou=users,dc=example,dc=org`)                          
       |
+| ldap_uri | string  | required    |         |       | the uri of the ldap 
server                                                                          
      |
+| use_tls  | boolean | optional    | `true`  |       | Boolean flag indicating 
if Transport Layer Security (TLS) should be used.                               
  |
+| uid      | string  | optional    | `cn`    |       | the `uid` attribute     
                                                                                
  |
+| user_dn  | string  | required    |         |       | the user dn of the 
`ladp` client (example: `cn=user01,ou=users,dc=example,dc=org`)                 
       |

Review comment:
       Hi @zaunist, thanks to pick this issue! Here has one sample from 
https://apisix.apache.org/docs/apisix/plugins/key-auth#attributes , and it 
splits attributes into 2 parts: For Consumer and For Route/Service, please take 
a look 😄




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to