bzp2010 commented on pull request #5734:
URL: https://github.com/apache/apisix/pull/5734#issuecomment-989892221


   Hi, @anderseknert. Glad to see your comments.
   
   > I would probably just let the user configure the full OPA URL rather than 
separating host, package and decision. In some cases you'll actually query a 
whole package, which is fine for OPA.
   
   Do you mean to merge host, package, decision together and use a single field 
(eg. `url`)?
   
   > The policy example (and from what I understand, the Lua code) only deals 
with boolean decisions. Maybe good to keep it simple, but could also be useful 
to allow OPA to return for example a reason for denying a request, and surface 
that to the caller. I don't see much in terms of documentation. Will that be 
added in a later PR?
   
   Features such as custom response codes, response headers and error causes 
will be added later in the PR. It will basically follow the roadmap section in 
#5714 to implement it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to