[GitHub] [apisix] tzssangglass commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level

[GitBox]

tzssangglass commented on a change in pull request #5839:
URL: https://github.com/apache/apisix/pull/5839#discussion_r772054988



##########
File path: apisix/plugins/google-cloud-logging.lua
##########
@@ -136,23 +136,23 @@ local function send_to_google(oauth, entries)
 end
 
 
-local function get_auth_config(config)
+local function get_auth_config(conf)
     if auth_config_cache then
         return auth_config_cache
     end
 
-    if config.auth_config then
-        auth_config_cache = config.auth_config
+    if conf.auth_config then
+        auth_config_cache = conf.auth_config
         return auth_config_cache
     end
 
-    if not config.auth_file then
+    if not conf.auth_file then
         return nil, "configuration is not defined"
     end

Review comment:
       why not use if ... else




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org