leslie-tsang commented on a change in pull request #5859:
URL: https://github.com/apache/apisix/pull/5859#discussion_r772160019
##########
File path: utils/install-dependencies.sh
##########
@@ -26,7 +26,7 @@ function detect_aur_helper() {
AUR_HELPER=pacaur
else
echo No available AUR helpers found. Please specify your AUR helper by
AUR_HELPER.
- exit -1
+ exit 1
Review comment:
> Every command returns an exit status (sometimes referred to as a
return status or exit code). A successful command returns a 0, while an
unsuccessful one returns a **non-zero value** that usually can be interpreted
as an error code. Well-behaved UNIX commands, programs, and utilities return a
0 exit code upon successful completion, though there are some exceptions.
Ref to [shell exit-status](https://tldp.org/LDP/abs/html/exit-status.html)
and [SC2242](https://github.com/koalaman/shellcheck/wiki/SC2242)
IMO, We should obey `SC2242` to make it more user friendly ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
