The-White-Lion commented on a change in pull request #5934:
URL: https://github.com/apache/apisix/pull/5934#discussion_r775738096
##########
File path: apisix/control/router.lua
##########
@@ -95,6 +96,14 @@ do
function fetch_control_api_router()
core.table.clear(routes)
+ local with_parameter = false
+ local conf = core.config.local_conf()
+ if conf.apisix.enable_control and conf.apisix.control then
Review comment:
> Could you update
https://github.com/apache/apisix/blob/master/docs/en/latest/control-api.md?
This is my oversight that forgot to update the related documention.
Now, I update
https://github.com/apache/apisix/blob/master/docs/en/latest/control-api.md and
https://github.com/apache/apisix/blob/master/docs/zh/latest/control-api.md.
> Could you move this block to the end of the function? Also, we can save
`conf.apisix.enable_control and ` as control API must be enabled if we hit this.
I moved this block to the end of the function.
Thanks for your patient guidanceļ¼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
