spacewander commented on a change in pull request #5831: URL: https://github.com/apache/apisix/pull/5831#discussion_r776957552
########## File path: apisix/plugins/file-logger.lua ########## @@ -0,0 +1,186 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NOTICE file distributed with +-- this work for additional information regarding copyright ownership. +-- The ASF licenses this file to You under the Apache License, Version 2.0 +-- (the "License"); you may not use this file except in compliance with +-- the License. You may obtain a copy of the License at +-- +-- http://www.apache.org/licenses/LICENSE-2.0 +-- +-- Unless required by applicable law or agreed to in writing, software +-- distributed under the License is distributed on an "AS IS" BASIS, +-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +-- See the License for the specific language governing permissions and +-- limitations under the License. +-- +local log_util = require("apisix.utils.log-util") +local core = require("apisix.core") +local plugin = require("apisix.plugin") +local ffi = require("ffi") +local bit = require("bit") +local C = ffi.C +local ngx = ngx +local io_open = io.open + + +local plugin_name = "file-logger" +local O_CREAT = 00000040 -- create and open +local O_APPEND = 00000400 -- add content to the end of +local O_WRONLY = 00000001 -- write only open +local S_IRUSR = 00400 -- user has read permission +local S_IWUSR = 00200 -- user has write permission +local S_IRGRP = 00040 -- group has read permission +local S_IROTH = 00004 -- others have read permission +local oflags = bit.bor(O_WRONLY, O_CREAT, O_APPEND) +local mode = bit.bor(S_IRUSR, S_IWUSR, S_IRGRP, S_IROTH) +local file_descriptors = {} + + +ffi.cdef [[ + int open(const char * filename, int flags, int mode); + int write(int fd, const void * ptr, int numbytes); + int close(int fd); +]] + + +local schema = { + type = "object", + properties = { + path = { + type = "string", + match = [[^[^*&%%\`]+$]], + err = "not a valid filename" + }, + }, + required = {"path"} +} + + +local metadata_schema = { + type = "object", + properties = { + log_format = log_util.metadata_schema_log_format + } +} + + +local _M = { + version = 0.1, + priority = 399, + name = plugin_name, + schema = schema, + metadata_schema = metadata_schema +} + + +function _M.check_schema(conf, schema_type) + if schema_type == core.schema.TYPE_METADATA then + return core.schema.check(metadata_schema, conf) + end + + local ok, err = core.schema.check(schema, conf) + if not ok then + return nil, err + end + return log_util.check_log_schema(conf) +end + + +local function reopen() + local target_pointer, err = io_open('logs/file_pointer', 'r') Review comment: Since only one worker can receive the reopen request, we can use worker event to trigger fd reopen in the other workers, like: https://github.com/apache/apisix/blob/cc09ef3b69089be62718455d9f919879bf28318b/apisix/discovery/consul_kv/init.lua#L376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
