leslie-tsang commented on a change in pull request #5984:
URL: https://github.com/apache/apisix/pull/5984#discussion_r777496977
##########
File path: apisix/plugins/limit-count.lua
##########
@@ -248,10 +250,11 @@ function _M.access(conf, ctx)
key = ctx.var["remote_addr"]
end
+ -- here we add a separator ':' to mark the boundary of the prefix and the
key itself
if not conf.group then
- key = key .. ctx.conf_type .. ctx.conf_version
+ key = ctx.conf_type .. ctx.conf_version .. ':' .. key
else
- key = key .. conf.group
+ key = conf.group .. ':' .. key
Review comment:
How about:
```bash
-- key format changed from `key*` to `*:key` for constant key type support
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
