This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new d3bb8f9 chore: only reviewer can mark the review resolved (#5994)
d3bb8f9 is described below
commit d3bb8f9035b14b35e2d2eccd0959ed00e8fe88e3
Author: 罗泽轩 <[email protected]>
AuthorDate: Tue Jan 4 12:07:58 2022 +0800
chore: only reviewer can mark the review resolved (#5994)
---
.github/PULL_REQUEST_TEMPLATE.md | 3 ++-
CONTRIBUTING.md | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 862a6ce..546bcea 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -5,13 +5,14 @@
### Pre-submission checklist:
<!--
-Please follow the requirements:
+Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please
merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the
review
+7. Only reviewer can click "Resolve conversation" to mark the reviewer's
review resolved
-->
* [ ] Did you explain what problem does this PR solve? Or what new features
have been added?
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index a418914..c76b6c6 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -48,6 +48,7 @@ Once we've discussed your changes and you've got your code
ready, make sure that
* References the original issue in the description, e.g. "Resolves #123".
* Has a [good commit
message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
* Ensure your pull request's title starts from one of the word in the `types`
section of
[semantic.yml](https://github.com/apache/apisix/blob/master/.github/semantic.yml).
+* Follow the [PR
manners](https://raw.githubusercontent.com/apache/apisix/master/.github/PULL_REQUEST_TEMPLATE.md)
## Contribution Guidelines for Documentation
