zaunist commented on a change in pull request #2283:
URL: https://github.com/apache/apisix-dashboard/pull/2283#discussion_r780043210
##########
File path: api/internal/handler/data_loader/route_import_test.go
##########
@@ -23,7 +23,8 @@ import (
"io/ioutil"
"mime/multipart"
"net/http"
- "os/exec"
+ "os"
+ "path"
Review comment:
Do we need to consider separate path for Windows? Ref
https://pkg.go.dev/path#pkg-overview, the `path` package does not support
Windows path.
```
This package does not deal with Windows paths with drive letters or
backslashes;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
