bzp2010 commented on a change in pull request #6037:
URL: https://github.com/apache/apisix/pull/6037#discussion_r780061628
##########
File path: apisix/core/request.lua
##########
@@ -278,6 +278,15 @@ function _M.get_path(ctx)
end
+function _M.get_uri(ctx)
Review comment:
So I should just use ctx.var.request_uri instead of wrapping it? Can I
merge the functionality of `get_path` into `get_uri` and add a `with_args`
parameter indicating whether or not I need to carry parameters.
##########
File path: apisix/core/request.lua
##########
@@ -278,6 +278,15 @@ function _M.get_path(ctx)
end
+function _M.get_uri(ctx)
Review comment:
So I should just use ctx.var.request_uri instead of wrapping it? Can I
merge the functionality of `get_path` into `get_uri` and add a `with_args`
parameter indicating whether or not I need to carry queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
