spacewander commented on a change in pull request #6055:
URL: https://github.com/apache/apisix/pull/6055#discussion_r780912270
##########
File path: apisix/utils/batch-processor.lua
##########
@@ -161,7 +161,7 @@ function batch_processor:push(entry)
local entries = self.entry_buffer.entries
table.insert(entries, entry)
-- add batch metric for every route
- if batch_metrics then
+ if batch_metrics and self.name and self.route_id and self.server_addr then
Review comment:
We could provide a default `''` for the route_id, right?
> Sometimes we need to judge whether matching route accroding to toute_id.
There is no need to judge with route_id for `error-log-logger`.
##########
File path: t/plugin/prometheus3.t
##########
@@ -90,3 +90,106 @@ passed
[200, 200]
--- no_error_log
[error]
+
+
+
+=== TEST 3: apisix_batch_process_entries, mess with global rules
Review comment:
Could you use the full file in
https://github.com/apache/apisix/pull/6047#issuecomment-1008495244 instead of
part of it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
