encanto-oss commented on a change in pull request #5923:
URL: https://github.com/apache/apisix/pull/5923#discussion_r775397628
##########
File path: apisix/plugins/openwhisk.lua
##########
@@ -30,6 +30,7 @@ local schema = {
},
service_token = {type = "string"},
namespace = {type = "string", maxLength = 256},
+ package = {type = "string", maxLength = 256},
Review comment:
added regex validation according to
[https://github.com/apache/openwhisk/blob/master/docs/reference.md#entity-names](https://github.com/apache/openwhisk/blob/master/docs/reference.md#entity-names)
```
local name_pattern = [[\A([\w]|[\w][\w@ .-]*[\[email protected]]+)\z]]
```
##########
File path: apisix/plugins/openwhisk.lua
##########
@@ -30,6 +30,7 @@ local schema = {
},
service_token = {type = "string"},
namespace = {type = "string", maxLength = 256},
+ package = {type = "string", maxLength = 256},
Review comment:
added regex validation according to
[https://github.com/apache/openwhisk/blob/master/docs/reference.md#entity-names](https://github.com/apache/openwhisk/blob/master/docs/reference.md#entity-names)
```lua
local name_pattern = [[\A([\w]|[\w][\w@ .-]*[\[email protected]]+)\z]]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
