spacewander commented on a change in pull request #6103:
URL: https://github.com/apache/apisix/pull/6103#discussion_r785262618
##########
File path: apisix/plugins/openid-connect.lua
##########
@@ -293,30 +293,28 @@ function _M.rewrite(plugin_conf, ctx)
-- the configured redirect URI after successful authentication.
response, err = openidc.authenticate(conf)
- if err then
+ if not response then
Review comment:
the openidc returns non-nil err to indicate something wrong, see:
https://github.com/zmartzone/lua-resty-openidc#sample-configuration-for-google-signin
https://github.com/zmartzone/lua-resty-openidc/blob/master/lib/resty/openidc.lua#L1494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
