spacewander commented on a change in pull request #6168:
URL: https://github.com/apache/apisix/pull/6168#discussion_r789285658



##########
File path: apisix/core/request.lua
##########
@@ -223,7 +223,7 @@ function _M.get_body(max_size, ctx)
 
     local file_name = req_get_body_file()
     if not file_name then
-        return nil
+        return nil, "request body has zero size"

Review comment:
       We can't do that as it will break ext-plugin, FaaS, and other plugins. 
What about  changing the graphQL code like that: 
https://github.com/apache/apisix/blob/e9fab8b2e5b5cb79a302faf8b5c9752766681c63/apisix/plugins/request-validation.lua#L83




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to