leslie-tsang commented on a change in pull request #6236:
URL: https://github.com/apache/apisix/pull/6236#discussion_r795145876



##########
File path: Makefile
##########
@@ -35,6 +35,7 @@ ENV_APISIX             ?= $(CURDIR)/bin/apisix
 ENV_GIT                ?= git
 ENV_TAR                ?= tar
 ENV_INSTALL            ?= install
+ENV_RM                 ?= rm

Review comment:
       ```suggestion
   ENV_RM                 ?= rm -vf
   ```
   let's extraction of public parts here, :)

##########
File path: Makefile
##########
@@ -340,6 +341,16 @@ install: runtime
        $(ENV_INSTALL) apisix/plugins/slslog/*.lua 
$(ENV_INST_LUADIR)/apisix/plugins/slslog/
 
 
+### uninstall : Uninstall the apisix
+.PHONY: uninstall
+uninstall:
+       @$(call func_echo_status, "$@ -> [ Start ]")
+       $(ENV_RM) -vfr /usr/local/apisix
+       $(ENV_RM) -vfr $(ENV_INST_LUADIR)/apisix
+       $(ENV_RM) -vf $(ENV_INST_BINDIR)/apisix

Review comment:
       ```suggestion
        $(ENV_RM) -r /usr/local/apisix
        $(ENV_RM) -r $(ENV_INST_LUADIR)/apisix
        $(ENV_RM) $(ENV_INST_BINDIR)/apisix
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to