zhixiongdu027 commented on a change in pull request #4880:
URL: https://github.com/apache/apisix/pull/4880#discussion_r802303317
##########
File path: apisix/discovery/kubernetes/informer_factory.lua
##########
@@ -152,48 +152,47 @@ local function split_event (body, dispatch_event)
remainder_body = string.sub(body, captured_size + 1)
end
- return remainder_body, "Success", nil
+ return remainder_body, "Success"
Review comment:
@membphis
Let's Imagine, if we use local ok ,body ,err way :
case error -> return false , nil, reason, err
case ok -> return true, remainer_body
and code in watch function will like
```lua
ok, remainer_body, reason, err = split_event(body, dispatch_event, informer)
if not ok then
if reason == "ResourceGone" then
return true
end
return false, reason, err
end
.....
```
is this what you expect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
