tzssangglass commented on a change in pull request #6314:
URL: https://github.com/apache/apisix/pull/6314#discussion_r807472751
##########
File path: apisix/plugins/hmac-auth.lua
##########
@@ -244,7 +244,13 @@ local function generate_signature(ctx, secret_key, params)
-- whether to encode the uri parameters
if type(param) == "table" then
+ local vals = {}
Review comment:
Not necessary to keep old code style here. We can specify the
initialization size when we create a new table by using `core.table.new(narray,
nhash)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
