spacewander commented on a change in pull request #6311:
URL: https://github.com/apache/apisix/pull/6311#discussion_r809627503
##########
File path: t/plugin/http-logger.t
##########
@@ -359,8 +362,9 @@ failed to perform SSL with host[127.0.0.1] port[8888]
handshake failed
"batch_max_size": 1,
"max_retry_count": 1,
"retry_delay": 2,
- "buffer_duration": 2,
- "inactive_timeout": 2
+ "buffer_duration": 1,
+ "inactive_timeout": 1,
+ "ssl_verify": true
Review comment:
As the certificate in the CI is self-signed, we need to use
`"ssl_verify": false` to make it pass.
##########
File path: t/plugin/http-logger.t
##########
@@ -820,3 +825,62 @@ failed to validate the 'include_resp_body_expr'
expression: invalid operator '<>
done
--- no_error_log
[error]
+
+
+
+=== TEST 19: ssl_verify default is false for comppatibaility
Review comment:
Could you use TEST 10, set `"ssl_verify": true`, and expect it to fail
in the `--- error_log`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
