spacewander commented on pull request #6340: URL: https://github.com/apache/apisix/pull/6340#issuecomment-1043880615
The shellcheck action is imported but doesn't run at all... To run it in the CI, we need to add it in https://github.com/apache/apisix/tree/master/.github/workflows. I think we should write our own GitHub action, like what we have done with editorconfig action: https://github.com/apache/apisix/pull/5391 The submodule way doesn't obey ASF's policy "Actions not from Github or ASF are forbidden.". It just bypass the restriction set in the CI. The policy maker of ASF won't be happy to see this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
