tokers commented on a change in pull request #6378: URL: https://github.com/apache/apisix/pull/6378#discussion_r810979588
########## File path: docs/en/latest/plugins/redirect.md ########## @@ -124,6 +124,17 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1 }' ``` +Testing based on the above examples : + +```shell +$ curl http://127.0.0.1:9080/hello -i +HTTP/1.1 301 Moved Permanently +... +Location: https://127.0.0.1/hello Review comment: Personally I think there is a bug, The generated Location header should respect the setting of SSL port, we cannot assume the SSL port is `443`. Also, my original meaning is quite simple, just because we use `9080` as the sample port to accept HTTP traffic in the doc, for the sake for consistence, I think using `9443` is better. If we use `80` to accept HTTP traffic, then using `443` is better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
