cmssczy commented on a change in pull request #875:
URL:
https://github.com/apache/apisix-ingress-controller/pull/875#discussion_r812521229
##########
File path: docs/en/latest/practices/the-hard-way.md
##########
@@ -443,11 +447,13 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: apisix-ingress-controller
+ namespace: apisix
Review comment:
This doc tells us to install apisix-ingress-controller manually but not
by helm. And all the configurations are all deployed in `apisix` namespace,
deployment/serviceAccount/clusterRole, etc. So I think we should specify this
parameter explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
