neverCase commented on a change in pull request #845:
URL:
https://github.com/apache/apisix-ingress-controller/pull/845#discussion_r812572951
##########
File path: pkg/kube/translation/apisix_route.go
##########
@@ -977,13 +964,6 @@ func (t *translator)
translateHTTPRouteV2beta3NotStrictly(ctx *TranslateContext,
route := apisixv1.NewDefaultRoute()
route.Name = apisixv1.ComposeRouteName(ar.Namespace, ar.Name,
part.Name)
route.ID = id.GenID(route.Name)
- pluginConfig := apisixv1.NewDefaultPluginConfig()
Review comment:
That's because when it creates the ApisixRoute and the field
`PluginConfigName` has been specified, I want to use apisix.Cluster api to
check the plugin was whether exist.
And at the same time replace it with the plugin id.
...
Since the method to generate the plugin id is fixed.
I will just remove the replacement and remain checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
