yzeng25 commented on a change in pull request #6464:
URL: https://github.com/apache/apisix/pull/6464#discussion_r815548684
##########
File path: docs/en/latest/architecture-design/plugin.md
##########
@@ -60,23 +64,28 @@ The plugin configuration is submitted as part of Route or
Service and placed und
}
```
-Not all plugins have specific configuration items. For example, there is no
specific configuration item under `prometheus`. In this case, an empty object
identifier can be used.
+Not all plugins have specific configuration items (for example,
[prometheus](/docs/apisix/plugins/prometheus/)). In such cases, an empty object
identifier can be used.
Review comment:
```suggestion
Not all Plugins have specific configuration items (for example,
[prometheus](/docs/apisix/plugins/prometheus/)). In such cases, an empty object
identifier can be used.
```
##########
File path: docs/en/latest/architecture-design/plugin.md
##########
@@ -60,23 +64,28 @@ The plugin configuration is submitted as part of Route or
Service and placed und
}
```
-Not all plugins have specific configuration items. For example, there is no
specific configuration item under `prometheus`. In this case, an empty object
identifier can be used.
+Not all plugins have specific configuration items (for example,
[prometheus](/docs/apisix/plugins/prometheus/)). In such cases, an empty object
identifier can be used.
Review comment:
For the word "Plugin", it'd be good to unified them all as `Plugin` or
`plugin`. I don't get the point when capitalizing some of them.
##########
File path: docs/en/latest/architecture-design/route.md
##########
@@ -21,19 +21,25 @@ title: Route
#
-->
-The route matches the client's request by defining rules, then loads and
executes the corresponding plugin based on the matching result, and forwards
the request to the specified Upstream.
+Routes matches the client's request based on defined rules, loads and executes
the corresponding [plugins](./plugin.md), and forwards the request to the
specified [Upstream](./upstream.md).
Review comment:
```suggestion
Routes match the client's request based on defined rules, loads and executes
the corresponding [plugins](./plugin.md), and forwards the request to the
specified [Upstream](./upstream.md).
```
##########
File path: docs/en/latest/architecture-design/plugin.md
##########
@@ -60,23 +64,28 @@ The plugin configuration is submitted as part of Route or
Service and placed und
}
```
-Not all plugins have specific configuration items. For example, there is no
specific configuration item under `prometheus`. In this case, an empty object
identifier can be used.
+Not all plugins have specific configuration items (for example,
[prometheus](/docs/apisix/plugins/prometheus/)). In such cases, an empty object
identifier can be used.
+
+A warn level log as shown below indicates that the request was rejected by the
Plugin.
+
+```shell
+ip-restriction exits with http status code 403
+```
-If a request is rejected by a plugin, there will be warn level log like
`ip-restriction exits with http status code 403`.
+## Hot Reload
-## Hot reload
+APISIX Plugins are hot-loaded.
-APISIX plugins are hot-loaded. No matter you add, delete or modify plugins,
and **update codes of plugins in disk**, you don't need to restart the service.
+This means that there is no need to restart the service if you add, delete,
modify plugins or even if you update the plugin code.
-If your APISIX node has the Admin API turned on, just send an HTTP request
through admin API:
+To hot-reload, you can send an HTTP request through the [Admin
API](docs/apisix/admin-api):
Review comment:
Is it supposed to be `docs/apisix/admin-api.md` instead? I see other
links has this `.md` suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
