soulbird commented on pull request #6498: URL: https://github.com/apache/apisix/pull/6498#issuecomment-1057745835
> > > > > > > > > > Hello there, I'm afraid this change will not have the desired effect. > > > BTW, Could you desc the PR more clearly ? :) > > > > > > As the example, we can run this python script like: > > ```shell > > ./patch_upstream_mtls.py testmtls ./client.pem ./client.key > > ``` > > > > > > > > > > > > > > > > > > > > > > > > it has four parameters, we expect it to work, but we will got 'bad argument'. > > ```python > if len(sys.argv) >= 5: > ``` > > Can you confirm that this [conditional judgment](https://github.com/apache/apisix/blob/ce8227aaf7e4f0b8aab6274c38deda6e7c243c9d/docs/en/latest/mtls.md?plain=1#L121) continues to obstruct the request's execution? Actuall, we expect it to work like: ```shell ./ssl.py ./server.pem ./server.key 'mtls.test.com' ``` or ```shell ./ssl.py ./server.pem ./server.key 'mtls.test.com' ./client_ca.pem 10 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
