cmssczy commented on issue #908:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/908#issuecomment-1062745431


   > ```go
   > if !validation.HasValueInSyncMap(c.watchingNamespaces) && 
len(c.watchingLabels) == 0 {
   >      // list all namespaces and put them all in c.watchingNamespaces
   > }
   > ```
   > 
   > Is this the right way?
   
   I think this is the right way to solve this problem.  We should put all 
exsiting namespaces in `watchingNamespaces` only when both 
`c.watchingNamespaces` and `c.watchingLabels` are empty.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to