tokers commented on a change in pull request #6562:
URL: https://github.com/apache/apisix/pull/6562#discussion_r822472758
##########
File path: apisix/cli/ops.lua
##########
@@ -513,6 +513,11 @@ Please modify "admin_key" in conf/config.yaml .
end
end
+ local proxy_mirror_timeout
Review comment:
```suggestion
local proxy_mirror_timeouts
```
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -765,6 +765,11 @@ http {
}
{% end %}
+ {% if proxy_mirror_timeout then %}
+ {% for k, v in pairs(proxy_mirror_timeout) do %}
+ proxy_{* k *}_timeout {* v *}ms;
Review comment:
This way we may pollute the nginx template, we may write some bad
directive like: "proxy_foo_timeout".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
