spacewander commented on a change in pull request #6512: URL: https://github.com/apache/apisix/pull/6512#discussion_r824318922
########## File path: t/plugin/recaptcha.t ########## @@ -0,0 +1,242 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +use t::APISIX 'no_plan'; + +log_level('debug'); Review comment: Is it necessary to use debug log level? ########## File path: t/plugin/recaptcha.t ########## @@ -0,0 +1,242 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +use t::APISIX 'no_plan'; + +log_level('debug'); +repeat_each(1); +no_long_string(); +no_root_location(); Review comment: Let's add ``` add_block_preprocessor(sub { my ($block) = @_; if (!$block->request) { $block->set_value("request", "GET /t"); } if (!$block->no_error_log && !$block->error_log) { $block->set_value("no_error_log", "[error]\n[alert]"); } }); ``` to remove the duplicate fields. ########## File path: t/plugin/recaptcha.t ########## @@ -0,0 +1,242 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +use t::APISIX 'no_plan'; + +log_level('debug'); +repeat_each(1); +no_long_string(); +no_root_location(); +run_tests; + + +__DATA__ + +=== TEST 1: sanity +--- config + location /t { + content_by_lua_block { + local plugin = require("apisix.plugins.recaptcha") + local ok, err = plugin.check_schema({ + # https://developers.google.com/recaptcha/docs/faq#id-like-to-run-automated-tests-with-recaptcha + secret_key = "6LeIxAcTAAAAAGG-vFI1TnRWxMZNFuojJ4WifJWe", # Google automated-tests secret key + parameter_source = "header", + parameter_name = "captcha", + response = { + content_type = "application/json; charset=utf-8", + status_code = 400, + body = "{\"message\":\"invalid captcha\"}\n" + } + }) + if not ok then + ngx.say(err) + end + + ngx.say("done") + } + } +--- request Review comment: Let's use this script to simplify the duplicate fields: ``` #!/usr/bin/env python # coding: utf-8 # Usage: ./simpify.py $test_filename import sys with open(sys.argv[1]) as f: lines = [l.rstrip() for l in f.readlines()] newlines = [] for i, l in enumerate(lines): if ((l == "GET /t" and lines[i-1] == "--- request") or (l == "[error]" and lines[i-1] == "--- no_error_log")): newlines = newlines[:-1] continue newlines.append(l) res = "\n".join(newlines) # print(res) with open(sys.argv[1], "w") as f: f.write(res + '\n') ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
