tokers commented on a change in pull request #248:
URL: https://github.com/apache/apisix-helm-chart/pull/248#discussion_r824545489



##########
File path: charts/apisix/README.md
##########
@@ -76,6 +76,8 @@ The following tables lists the configurable parameters of the 
apisix chart and t
 | `apisix.luaModuleHook.configMapRef.name` | Name of the ConfigMap where the 
lua module codes store | "" |
 | `apisix.luaModuleHook.configMapRef.mounts[].key` | Name of the ConfigMap 
key, for setting the mapping relationship between ConfigMap key and the lua 
module code path. | `""` |
 | `apisix.luaModuleHook.configMapRef.mounts[].path` | Filepath of the plugin 
code, for setting the mapping relationship between ConfigMap key and the lua 
module code path. | `""` |
+| `extraVolumes` | Additional `volume`, [k8s docs 
volumes](https://kubernetes.io/docs/concepts/storage/volumes/). | `[]` |
+| `extraVolumeMounts` | Additional `volumeMounts`, [k8s docs 
volumes](https://kubernetes.io/docs/concepts/storage/volumes/). | `[]` |

Review comment:
       ```suggestion
   | `extraVolumeMounts` | Additional `volumeMounts`, See [Kubernetes 
Volumes](https://kubernetes.io/docs/concepts/storage/volumes/) for the detail. 
| `[]` |
   ```

##########
File path: charts/apisix/README.md
##########
@@ -76,6 +76,8 @@ The following tables lists the configurable parameters of the 
apisix chart and t
 | `apisix.luaModuleHook.configMapRef.name` | Name of the ConfigMap where the 
lua module codes store | "" |
 | `apisix.luaModuleHook.configMapRef.mounts[].key` | Name of the ConfigMap 
key, for setting the mapping relationship between ConfigMap key and the lua 
module code path. | `""` |
 | `apisix.luaModuleHook.configMapRef.mounts[].path` | Filepath of the plugin 
code, for setting the mapping relationship between ConfigMap key and the lua 
module code path. | `""` |
+| `extraVolumes` | Additional `volume`, [k8s docs 
volumes](https://kubernetes.io/docs/concepts/storage/volumes/). | `[]` |

Review comment:
       ```suggestion
   | `extraVolumes` | Additional `volume`, See [Kubernetes 
Volumes](https://kubernetes.io/docs/concepts/storage/volumes/) for the detail. 
| `[]` |
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to