guoqqqi commented on a change in pull request #2359:
URL: https://github.com/apache/apisix-dashboard/pull/2359#discussion_r825272252
##########
File path:
web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
##########
@@ -88,6 +91,8 @@ context('Create Configure and Delete PluginTemplate', () => {
cy.get(selector.description).clear().type(data.pluginTemplateName2);
cy.contains('Next').click();
cy.contains('Next').click();
+ cy.contains(selector.pluginCard, 'basic-auth').should('be.visible');
+ cy.contains(selector.pluginTitle, 'Authentication').should('be.visible');
Review comment:
ditto
##########
File path:
web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
##########
@@ -74,6 +75,8 @@ context('Create Configure and Delete PluginTemplate', () => {
cy.contains('Submit').click();
cy.contains('Next').click();
+ cy.contains(selector.pluginCard, 'basic-auth').should('be.visible');
+ cy.contains(selector.pluginTitle, 'Authentication').should('be.visible');
Review comment:
We'd better add assertions to determine that other category plugins
don't exist
##########
File path: web/src/components/Plugin/PluginPage.tsx
##########
@@ -92,6 +92,14 @@ const PluginPage: React.FC<Props> = ({
form.setFieldsValue({ plugin_config_id });
});
}, []);
+ console.log('initialData: ', initialData);
Review comment:
please remove this console
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
