zaunist commented on a change in pull request #2347: URL: https://github.com/apache/apisix-dashboard/pull/2347#discussion_r825534996
########## File path: web/src/components/Upstream/typings.d.ts ########## @@ -19,7 +19,11 @@ * Schema: https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L335 */ declare namespace UpstreamComponent { - type ActiveCheck = {}; + type ActiveCheck = { + url?: string; + host?: string; + http_path?: string; Review comment: IMO, this is to merge two input boxes into one, right? so why are there two fields, http_path and host? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
