spacewander commented on a change in pull request #6579:
URL: https://github.com/apache/apisix/pull/6579#discussion_r825575693
##########
File path: t/plugin/prometheus3.t
##########
@@ -256,7 +256,12 @@ passed
GET /opentracing
--- response_body
opentracing
---- grep_error_log eval
-qr/prometheus run \w+/
---- grep_error_log_out
-prometheus run report
+--- error_code: 200
Review comment:
The error_code check here is redundant?
##########
File path: t/plugin/prometheus3.t
##########
@@ -256,7 +256,12 @@ passed
GET /opentracing
--- response_body
opentracing
---- grep_error_log eval
-qr/prometheus run \w+/
---- grep_error_log_out
-prometheus run report
+--- error_code: 200
+
+
+
+=== TEST 7: fetch prometheus plugin at both global rule and route data
+--- request
+GET /apisix/prometheus/metrics
+--- response_body eval
+qr/apisix_http_status\{code="200",route="1",matched_uri="\/opentracing",matched_host="",service="",consumer="",node="127.0.0.1\"}
\d+/
Review comment:
It doesn't check the number this request is hit...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
