tao12345666333 commented on a change in pull request #920:
URL:
https://github.com/apache/apisix-ingress-controller/pull/920#discussion_r826073300
##########
File path: pkg/kube/apisix_plugin_config.go
##########
@@ -22,14 +22,14 @@ import (
)
const (
- // ApisixPluginConfigV2beta3 represents the ApisixPluginConfig in
apisix.apache.org/v2beta3 group version
- ApisixPluginConfigV2beta3 = "apisix.apache.org/v2beta3"
+ // ApisixPluginConfigV2beta3 represents the ApisixPluginConfig in
apisix.apache.org/GetV2beta3 group version
+ ApisixPluginConfigV2beta3 = "apisix.apache.org/GetV2beta3"
Review comment:
I don't think it should be modified here
##########
File path: pkg/kube/ingress.go
##########
@@ -26,22 +26,22 @@ import (
)
const (
- // IngressV1 represents the Ingress in networking/v1 group version.
- IngressV1 = "networking/v1"
- // IngressV1beta1 represents the Ingress in networking/v1beta1 group
version.
- IngressV1beta1 = "networking/v1beta1"
- // IngressExtensionsV1beta1 represents the Ingress in
extensions/v1beta1 group version.
- IngressExtensionsV1beta1 = "extensions/v1beta1"
+ // IngressV1 represents the Ingress in networking/V1 group version.
+ IngressV1 = "networking/V1"
Review comment:
these are also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
