juzhiyuan commented on a change in pull request #6610:
URL: https://github.com/apache/apisix/pull/6610#discussion_r826674718
##########
File path: docs/en/latest/terminology/route.md
##########
@@ -21,11 +21,13 @@ title: Route
#
-->
-Routes match the client's request based on defined rules, loads and executes
the corresponding [plugins](./plugin.md), and forwards the request to the
specified [Upstream](./upstream.md).
+## Description
+
+Routes match the client's request based on defined rules, load and execute the
corresponding [plugins](./plugin.md), and forwards the request to the specified
[Upstream](./upstream.md).
A Route mainly consists of three parts:
-1. Matching rules (uri, host, remote address)
+1. Matching rules (`uri`, `host`, `remote address)
Review comment:
```suggestion
1. Matching rules (`uri`, `host`, `remote address`)
```
##########
File path: docs/en/latest/architecture-design/debug-mode.md
##########
@@ -63,10 +63,10 @@ The checker would only check this if the file was updated
by checking its last m
| Key | Optional | Description
| Default |
| ------------------------------- | -------- |
-----------------------------------------------------------------------------------------------------------------------------------------
| ------- |
| hook_conf.enable | required | Enable/Disable hook debug
trace. Target module function's input arguments or returned value would be
printed once this option is enabled. | false |
-| hook_conf.name | required | The module list name of the
hook which has enabled debug trace.
| |
-| hook_conf.log_level | required | Logging levels for input
arguments & returned values.
| warn |
-| hook_conf.is_print_input_args | required | Enable/Disable printing input
arguments.
| true |
-| hook_conf.is_print_return_value | required | Enable/Disable printing
returned values.
| true |
+| hook_conf.name | required | The module list name of the
hook which has enabled debug trace.
| |
+| hook_conf.log_level | required | Logging levels for input
arguments & returned values.
| warn |
+| hook_conf.is_print_input_args | required | Enable/Disable printing input
arguments.
| true |
+| hook_conf.is_print_return_value | required | Enable/Disable printing
returned values.
| true |
Review comment:
I don't see changes in this section, not sure why GitHub highlighted
this part.
##########
File path: docs/en/latest/config.json
##########
@@ -6,18 +6,25 @@
"label": "Architecture Design",
"items": [
"architecture-design/apisix",
- "architecture-design/route",
- "architecture-design/plugin",
- "architecture-design/script",
- "architecture-design/service",
- "architecture-design/consumer",
- "architecture-design/upstream",
- "architecture-design/global-rule",
"architecture-design/plugin-config",
- "architecture-design/router",
"architecture-design/debug-mode"
]
},
+ {
+ "type": "category",
+ "label": "Terminology",
+ "items": [
+ "terminology/api-gateway",
Review comment:
cc @membphis, if we need to adjust those items' order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
