wilson-1024 commented on pull request #6600:
URL: https://github.com/apache/apisix/pull/6600#issuecomment-1068704349


   @spacewander  I applied this patch directly, but my local test fails.Please 
help me.
   result:
   ```
    FLUSH_ETCD=1 prove -I. -I../test-nginx/ -I../test-nginx/lib -r  
t/node/upstream.t
   t/node/upstream.t .. 66/? 
   #   Failed test 't/node/upstream.t TEST 24: hit route - pattern "Host: 
127.0.0.1:1979" should match a line in error.log (req 0)'
   #   at 
/Users/zenghuilin/github/apisix/../test-nginx/lib/Test/Nginx/Socket.pm line 
1284.
   # Looks like you failed 1 test of 71.
   t/node/upstream.t .. Dubious, test returned 1 (wstat 256, 0x100)
   Failed 1/71 subtests 
   
   Test Summary Report
   -------------------
   t/node/upstream.t (Wstat: 256 Tests: 71 Failed: 1)
     Failed test:  71
     Non-zero exit status: 1
   Files=1, Tests=71, 12 wallclock secs ( 0.03 usr  0.00 sys +  1.52 cusr  0.89 
csys =  2.44 CPU)
   Result: FAIL
   ```
   file diff
   ```diff
   diff --git a/t/node/upstream.t b/t/node/upstream.t
   index feee95bd..c73b8391 100644
   --- a/t/node/upstream.t
   +++ b/t/node/upstream.t
   @@ -565,10 +565,8 @@ passed
    --- request
    GET /uri
    --- skip_nginx: 5: < 1.19.0
   ---- response_body
   -uri: /uri
   -host: localhost:1980
   -x-real-ip: 127.0.0.1
   +--- response_body eval
   +qr/host: localhost:1980/
    --- no_error_log
    [error]
    
   @@ -614,7 +612,6 @@ x-real-ip: 127.0.0.1
        }
    --- request
    GET /t
   ---- skip_nginx: 5: < 1.19.0
    --- response_body
    passed
    --- no_error_log
   @@ -623,12 +620,10 @@ passed
    
    
    === TEST 24: hit route
   +--- log_level: debug
    --- request
    GET /uri
   ---- skip_nginx: 5: < 1.19.0
   ---- response_body
   -uri: /uri
   -host: localhost:1980
   -x-real-ip: 127.0.0.1
   +--- response_body eval
   +qr/host: localhost:1980/
    --- error_log
   -proxy request to 127.0.0.1:1980
   +Host: 127.0.0.1:1979
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to