spacewander commented on issue #6580: URL: https://github.com/apache/apisix/issues/6580#issuecomment-1076972399
> @tokers That's a legitimate concern. What about: > > ```shell > $ curl -i https://my.host/apisix/admin/plugin_configs/1 -H 'X-API-KEY: abc' -X PUT -d '{ > "desc": "blah", > "plugins": { > "limit-count": { > "priority": 500, > "conf": [ > { > "time_window": 60, > "count": 10, > "key": "remote_addr" > }, > { > "time_window": 1, > "count": 5, > "key": "route_id" > } > ] > }, > "ip-restriction": { > "priority": 200, > "conf": [ > { > "whitelist": [ > "127.0.0.1", > "113.74.26.106/24" > ] > } > ] > } > } > }' > ``` From a developer's aspect, it is hard to distinguish this from the current arch, as "priority" / "conf" can be a valid field. What about using a new field instead of "plugins" for the route conf? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
