juzhiyuan commented on a change in pull request #6668:
URL: https://github.com/apache/apisix/pull/6668#discussion_r833985582
##########
File path: docs/zh/latest/plugins/csrf.md
##########
@@ -29,11 +29,11 @@ title: csrf
## 属性
-| Name | Type | Requirement | Default | Valid | Description
|
+| 名称 | 类型 | 必选项 | 默认值 | 有效值 | 描述
|
| ---------------- | ------- | ----------- | ------- | ----- |
------------------------------------------------------------ |
-| name | string | optional | `apisix-csrf-token` | | 生成的 Cookie
中的 token 的名字，需要使用这个名字在请求头携带 Cookie 中的内容 |
-| expires | number | optional | `7200` | | CSRF Cookie 的过期时间(秒) |
-| key | string | required | | | 加密 token 的秘钥 |
+| name | string | 可选 | `apisix-csrf-token` | | 生成的 Cookie 中的
token 的名字，需要使用这个名字在请求头携带 Cookie 中的内容 |
+| expires | number | 可选 | `7200` | | CSRF Cookie 的过期时间(秒) |
+| key | string | 必选 | | | 加密 token 的秘钥 |
Review comment:
I just checked Stripe and GitHub's API References, they're different
from Apache APISIX API References.
I have two styles:
1. Required (必填) -> Yes, No
2. Optional (可选) -> Required （必填）, Optional（可选）
After consideration, how about using `Required` as column name? also cc
@navendu-pottekkat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
