guoqqqi commented on a change in pull request #2393:
URL: https://github.com/apache/apisix-dashboard/pull/2393#discussion_r838051837
##########
File path: web/src/pages/PluginTemplate/List.tsx
##########
@@ -182,13 +182,18 @@ const Page: React.FC = () => {
/>
<RawDataEditor
visible={visible}
- type="service"
- readonly={true}
+ type="PluginTemplate"
+ readonly={false}
data={rawData}
onClose={() => {
setVisible(false);
}}
onSubmit={(data: any) => {
+ handleTableActionSuccessResponse(
+ `${formatMessage({ id: 'component.global.submit' })}
${formatMessage({
+ id: 'component.status.success',
+ })}`,
+ );
Review comment:
we can use the notification, refer to `notification`
https://ant.design/components/notification-cn/
##########
File path: web/src/pages/PluginTemplate/List.tsx
##########
@@ -182,13 +182,18 @@ const Page: React.FC = () => {
/>
<RawDataEditor
visible={visible}
- type="service"
- readonly={true}
+ type="PluginTemplate"
+ readonly={false}
data={rawData}
onClose={() => {
setVisible(false);
}}
onSubmit={(data: any) => {
+ handleTableActionSuccessResponse(
+ `${formatMessage({ id: 'component.global.submit' })}
${formatMessage({
+ id: 'component.status.success',
Review comment:
Use one key, not two
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
