membphis commented on a change in pull request #6759:
URL: https://github.com/apache/apisix/pull/6759#discussion_r841002003
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -244,7 +244,8 @@ http {
{% end %}
{% if config_center == "xds" then %}
- lua_shared_dict xds-route-config 10m;
+ lua_shared_dict xds-config 10m;
+ lua_shared_dict xds-conf-version 1m;
Review comment:
how about `xds-config-version`?
##########
File path: t/APISIX.pm
##########
@@ -509,7 +509,8 @@ _EOC_
lua_shared_dict ext-plugin 1m;
lua_shared_dict kubernetes 1m;
lua_shared_dict tars 1m;
- lua_shared_dict xds-route-config 1m;
+ lua_shared_dict xds-config 1m;
+ lua_shared_dict xds-conf-version 1m;
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]