yzeng25 commented on PR #1024: URL: https://github.com/apache/apisix-website/pull/1024#issuecomment-1098066781
LGTM except couple some neats. 1. Changes in `yarn.lock` files should not be included. This file should remain the same. Please fix it. 2. Please modify your **pull request title** and **description** to something shorter in length. - Something like `chore: add translation for "Resource" button` for the pull request title; - Something like `Changes: In Chinese language, the "Resource" button in navigation bar needs to be translated into - -Chinese` for description would be way better. - Delete the `Fixes: #[Add issue number here]` part, since there is not an issue for it (You can definitely create an issue as well but it is up to you). - A couple of screenshots to show the before/after could help as well. cc @Baoyuantop @guoqqqi @bzp2010 @juzhiyuan @SkyeYoung -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
