Gallardot commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r853101315


##########
charts/apisix/values.yaml:
##########
@@ -312,6 +312,12 @@ logs:
   errorLog: "/dev/stderr"
   errorLogLevel: "warn"
 
+core:
+  worker_rlimit_nofile: 20480
+  events:
+    worker_connections: 10620
+    use: epoll

Review Comment:
   ref: [ngx_core_module](http://nginx.org/en/docs/ngx_core_module.html#use) 
and [events](http://nginx.org/en/docs/events.html) 
   
   ```
   There is normally no need to specify it explicitly, because nginx will by 
default use the most efficient method.
   ```
   
   So is it better to default to nil?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to