zhendongcmss commented on code in PR #6908:
URL: https://github.com/apache/apisix/pull/6908#discussion_r856935951
##########
apisix/schema_def.lua:
##########
@@ -37,7 +37,7 @@ local id_schema = {
}
}
-local host_def_pat = "^\\*?[0-9a-zA-Z-._]+$"
+local host_def_pat = "^\\*?[0-9a-zA-Z-._\\[\\]:]+$"
Review Comment:
My point that it is hard to use the same regular exprssion to valitate ipv4
and ipv6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
