tokers commented on code in PR #975:
URL:
https://github.com/apache/apisix-ingress-controller/pull/975#discussion_r857421134
##########
pkg/kube/translation/annotations/redirect.go:
##########
@@ -15,11 +15,15 @@
package annotations
import (
+ "strconv"
+
apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
)
const (
- _httpToHttps = AnnotationsPrefix + "http-to-https"
+ _httpToHttps = AnnotationsPrefix + "http-to-https"
+ _permanentRedirect = AnnotationsPrefix + "permanent-redirect"
+ _permanentRedirectCode = AnnotationsPrefix + "permanent-redirect-code"
Review Comment:
I mean, we should only allow users configuring `301` or `308` here. If I
configure a `302` code here, it doesn't comply the HTTP semantic, because `302`
is a "temporarily" redirect, but what we want is "permanent".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
