soulbird commented on PR #7007:
URL: https://github.com/apache/apisix/pull/7007#issuecomment-1120595331

   > This port change problem should be covered with test cases
   
   I think it is not necessary to add test coverage related to the default 
port, and the success or failure of the report will not affect the operation of 
APISIX. You can see that the `do_request` function does not return any relevant 
error information, it just output a log. Look: 
https://github.com/yangxikun/opentelemetry-lua/blob/main/lib/opentelemetry/trace/exporter/http_client.lua#L30
   cc @spacewander 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to