kwanhur commented on code in PR #7006:
URL: https://github.com/apache/apisix/pull/7006#discussion_r868104749
##########
apisix/cli/ops.lua:
##########
@@ -728,14 +729,16 @@ local function start(env, ...)
local pid = util.read_file(pid_path)
pid = tonumber(pid)
if pid then
- local lsof_cmd = "lsof -p " .. pid
- local res, err = util.execute_cmd(lsof_cmd)
- if not (res and res == "") then
- if not res then
- print(err)
- else
- print("APISIX is running...")
- end
+ local signone = 0
+ local errno_noproc = 3
Review Comment:
It can, but no constants defined at module level now, there are many
constant variables in `ops.lua`.
Maybe they doesn't hurt the performance as used a command-line tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
