spacewander commented on code in PR #6949:
URL: https://github.com/apache/apisix/pull/6949#discussion_r868765977
##########
apisix/plugins/api-breaker.lua:
##########
@@ -35,6 +37,23 @@ local schema = {
minimum = 200,
maximum = 599,
},
+ break_response_body = {
+ type = "string"
+ },
+ headers = {
+ type = "array",
+ items = {
+ type = "object",
+ properties = {
+ key = {
+ type = "string"
Review Comment:
Let's add "minLength = 1" to avoid empty string
##########
apisix/plugins/api-breaker.lua:
##########
@@ -35,6 +37,23 @@ local schema = {
minimum = 200,
maximum = 599,
},
+ break_response_body = {
+ type = "string"
+ },
+ headers = {
Review Comment:
```suggestion
break_response_headers = {
```
would be better
##########
apisix/plugins/api-breaker.lua:
##########
@@ -35,6 +37,23 @@ local schema = {
minimum = 200,
maximum = 599,
},
+ break_response_body = {
+ type = "string"
+ },
+ headers = {
+ type = "array",
+ items = {
+ type = "object",
+ properties = {
+ key = {
+ type = "string"
+ },
+ value = {
+ type = "string"
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
