bzp2010 commented on code in PR #7046:
URL: https://github.com/apache/apisix/pull/7046#discussion_r874410084
##########
apisix/upstream.lua:
##########
@@ -435,7 +435,7 @@ local function check_upstream_conf(in_dp, conf)
end
end
- if conf.tls then
+ if conf.tls and conf.tls.client_cert and conf.tls.client_key then
Review Comment:
Yes, it's enough, we ensure `client_cert` and `client_key` both exist by
jsonschema's dependencies. Any one of them separate existence is forbidden.
https://github.com/apache/apisix/blob/99bced123eb4d63e66be191b68a6da17b8aac150/apisix/schema_def.lua#L416-L419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
