tzssangglass commented on code in PR #7049:
URL: https://github.com/apache/apisix/pull/7049#discussion_r874917476


##########
t/cli/test_admin.sh:
##########
@@ -112,6 +113,66 @@ if [ $count -eq 0 ]; then
     exit 1
 fi
 
+echo "
+apisix:
+    enable_admin: true
+    allow_admin:
+        - 127.0.0.0/8
+" > conf/config.yaml
+
+make init
+
+count=`grep -c "allow 127.0.0.0/8" conf/nginx.conf`
+if [ $count -eq 0 ]; then

Review Comment:
   Not sure I understand what the purpose of using count here is? Worried about 
other configurations also 
   `listen 127.0.0.0/8` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to