mangoGoForward commented on issue #547: URL: https://github.com/apache/apisix-ingress-controller/issues/547#issuecomment-1129733478
Hi @tao12345666333 . On the implementation, I want to confirm a few things: 1. We should add `sni` in types. https://github.com/apache/apisix-ingress-controller/blob/3cccd5666e098f374c262eb443de194d69d6a55e/pkg/types/apisix/v1/types.go#L331-L339 2. When `ApisixRoute` translate to `StreamRoute`, we should add `sni` to `StreamRoute` instance? https://github.com/apache/apisix-ingress-controller/blob/3cccd5666e098f374c262eb443de194d69d6a55e/pkg/kube/translation/apisix_route.go#L732 then create or update it. But I am confused about that which field in `ApisixRoute` we can use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
