spacewander commented on code in PR #7079:
URL: https://github.com/apache/apisix/pull/7079#discussion_r876592117
##########
apisix/cli/ops.lua:
##########
@@ -602,6 +602,10 @@ Please modify "admin_key" in conf/config.yaml .
end
for i, r in ipairs(sys_conf["dns_resolver"]) do
+ local res, err = cli_ip.valid(r)
+ if not res then
+ util.die("invalid dns resolver address: ", r, ", err: ", err)
Review Comment:
Would be better to ignore the unexpected resolver instead of dying of it?
And we can add a warn log for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
